Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1429: update notificaiton model for encrypted field #19839

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ianperera
Copy link
Contributor

@ianperera ianperera commented Dec 11, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

  • *This work is behind a feature toggle (flipper): YES

  • (Summarize the changes that have been made to the platform) Add lockbox encryption to the "to" field on notification callbacks

  • *(If bug, how to reproduce) N/A

  • (What is the solution, why is this the solution?)

  • *(Which team do you work for, does your team own the maintenance of this component?) VA Notify

  • (If introducing a flipper, what is the success criteria being targeted?)

Related issue(s)

https://github.com/orgs/department-of-veterans-affairs/projects/1415/views/1?pane=issue&itemId=88343529&issue=department-of-veterans-affairs%7Cvanotify-team%7C1429

  • New code is covered by unit tests
  • Describe what the old behavior was prior to the change
  • Describe the steps required to verify your changes are working as expected. Exclusively stating 'Specs run' is NOT acceptable as appropriate testing
  • If this work is behind a flipper:
    • Tests need to be written for both the flipper on and flipper off scenarios. Docs.
    • What is the testing plan for rolling out the feature?

Screenshots

Note: Optional

What areas of the site does it impact?

(Describe what parts of the site are impacted andifcode touched other areas)

Acceptance criteria

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No error nor warning in the console.
  • Events are being sent to the appropriate logging solution
  • Documentation has been updated (link to documentation)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Feature/bug has a monitor built into Datadog (if applicable)
  • If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
  • I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 11, 2024 18:35 Inactive
@ianperera ianperera marked this pull request as ready for review December 16, 2024 15:27
@ianperera ianperera requested review from a team as code owners December 16, 2024 15:27
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 16, 2024 15:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 17, 2024 15:08 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 17, 2024 19:05 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 18, 2024 15:55 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 18, 2024 20:18 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 19, 2024 10:20 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 20, 2024 15:58 Inactive
@ryan-mcneil
Copy link
Contributor

@ianperera merging master should fix that broke test

@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 20, 2024 21:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to ip/1429-v2/main/main December 23, 2024 03:52 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants